Skip to content

Conversation

@Huuums
Copy link
Contributor

@Huuums Huuums commented Dec 4, 2020

Dennis Collon added 2 commits December 4, 2020 12:48
@Huuums
Copy link
Contributor Author

Huuums commented Dec 4, 2020

after checking out the other issues I also added a fix for #68

Huuums and others added 2 commits December 7, 2020 08:48
Co-authored-by: Carl Vitullo <vcarl@users.noreply.github.com>
@@ -0,0 +1,18 @@
# Contributing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this is super awesome to have, thanks for adding it.

Copy link
Member

@vcarl vcarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd like to adjust the format of the message we send (a ` within the message I think will bork the formatting as-is) but that's not a blocker for merging. Thanks for doing this!!

@vcarl vcarl merged commit 1fdad2c into reactiflux:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DM members who receive a ⚠️ warning from moderators

2 participants