This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
feat: allow applied order surcharges to have any shape #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
kieckhafer
approved these changes
Apr 28, 2020
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Changes
Companion to reactioncommerce/api-plugin-surcharges#3
Applied surcharge fields are no longer validated when being applied to an order. Any object with any fields is allowed. Responsibility is passed to the
surchargesplugin to validate before returning them.This makes it easier for plugins to override the AppliedSurcharge schema, since it is stored by both carts and orders.
Breaking changes
None
Testing
Probably easiest to merge after code review and test together with reactioncommerce/api-plugin-surcharges#3