Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spiderable does not work #335

Closed
gouthamve opened this issue Mar 6, 2015 · 14 comments
Closed

Spiderable does not work #335

gouthamve opened this issue Mar 6, 2015 · 14 comments

Comments

@gouthamve
Copy link
Contributor

When I do escaped_fragment on my reaction shop, I got:

I20150306-15:26:05.211(5.5)? spiderable: phantomjs not installed. Download and install from http://phantomjs.org/
W20150306-15:26:05.251(5.5)? (STDERR) Error: Meteor code must always run within a Fiber. Try wrapping callbacks that you pass to non-Meteor libraries with Meteor.bindEnvironment.
W20150306-15:26:05.251(5.5)? (STDERR)     at Object.Meteor._nodeCodeMustBeInFiber (packages/meteor/dynamics_nodejs.js:9:1)
W20150306-15:26:05.251(5.5)? (STDERR)     at [object Object]._.extend.get (packages/meteor/dynamics_nodejs.js:21:1)
W20150306-15:26:05.252(5.5)? (STDERR)     at [object Object].RouteController.lookupOption (packages/iron:router/lib/route_controller.js:66:1)
W20150306-15:26:05.252(5.5)? (STDERR)     at new Controller.extend.constructor (packages/iron:router/lib/route_controller.js:26:1)
W20150306-15:26:05.252(5.5)? (STDERR)     at [object Object].ctor (packages/iron:core/lib/iron_core.js:88:1)
W20150306-15:26:05.252(5.5)? (STDERR)     at Function.Router.createController (packages/iron:router/lib/router.js:201:1)
W20150306-15:26:05.252(5.5)? (STDERR)     at Function.Router.dispatch (packages/iron:router/lib/router_server.js:39:1)
W20150306-15:26:05.252(5.5)? (STDERR)     at Object.router (packages/iron:router/lib/router.js:15:1)
W20150306-15:26:05.252(5.5)? (STDERR)     at next (/Users/goutham/.meteor/packages/webapp/.1.1.6.112vqtg++os+web.browser+web.cordova/npm/node_modules/connect/lib/proto.js:190:15)
W20150306-15:26:05.252(5.5)? (STDERR)     at Object.Package [as handle] (packages/cfs:http-methods/http.methods.server.api.js:417:1)

After installing Phantom, I am still getting:

I20150306-15:33:30.776(5.5)? spiderable: phantomjs failed: { [Error: Command failed: ] killed: false, code: null, signal: 'SIGKILL' } 
I20150306-15:33:30.776(5.5)? stderr: 
W20150306-15:33:30.812(5.5)? (STDERR) Error: Meteor code must always run within a Fiber. Try wrapping callbacks that you pass to non-Meteor libraries with Meteor.bindEnvironment.
W20150306-15:33:30.812(5.5)? (STDERR)     at Object.Meteor._nodeCodeMustBeInFiber (packages/meteor/dynamics_nodejs.js:9:1)
W20150306-15:33:30.813(5.5)? (STDERR)     at [object Object]._.extend.get (packages/meteor/dynamics_nodejs.js:21:1)
W20150306-15:33:30.813(5.5)? (STDERR)     at [object Object].RouteController.lookupOption (packages/iron:router/lib/route_controller.js:66:1)
W20150306-15:33:30.813(5.5)? (STDERR)     at new Controller.extend.constructor (packages/iron:router/lib/route_controller.js:26:1)
W20150306-15:33:30.814(5.5)? (STDERR)     at [object Object].ctor (packages/iron:core/lib/iron_core.js:88:1)
W20150306-15:33:30.814(5.5)? (STDERR)     at Function.Router.createController (packages/iron:router/lib/router.js:201:1)
W20150306-15:33:30.814(5.5)? (STDERR)     at Function.Router.dispatch (packages/iron:router/lib/router_server.js:39:1)
W20150306-15:33:30.815(5.5)? (STDERR)     at Object.router (packages/iron:router/lib/router.js:15:1)
W20150306-15:33:30.815(5.5)? (STDERR)     at next (/Users/goutham/.meteor/packages/webapp/.1.1.6.112vqtg++os+web.browser+web.cordova/npm/node_modules/connect/lib/proto.js:190:15)
W20150306-15:33:30.815(5.5)? (STDERR)     at Object.Package [as handle] (packages/cfs:http-methods/http.methods.server.api.js:417:1)
@aaronjudd aaronjudd added the ready label Mar 6, 2015
@kifirkin
Copy link
Contributor

kifirkin commented Mar 8, 2015

I can test it a bit later

@aaronjudd
Copy link
Contributor

@gouthamve how is your test deployed? just a local meteor run? No proxies, docker, vagrant,etc?

@gouthamve
Copy link
Contributor Author

Yes, just a local meteor

@gouthamve
Copy link
Contributor Author

And I do have a proxy. But I am running locally so I don't think it should affect anything. But I think cfs:http-methods is causing that problem.

See: https://github.com/CollectionFS/Meteor-http-methods/issues/29

@aaronjudd
Copy link
Contributor

Well, that sure looks like the issue.
There is this... meteor/meteor#2429 which is why I asked about the environment. I wonder if the two issues are related.

Any chance you are setting ROOT_URL?

@gouthamve
Copy link
Contributor Author

Actually no, I am not setting the ROOT_URL anywhere. If it defaults to localhost it will be right.

@aaronjudd aaronjudd added bug and removed ready labels Mar 16, 2015
@aaronjudd
Copy link
Contributor

I've tested locally: curl http://localhost:3000/?_escaped_fragment_= works fine there... so I think it's an environment issue with the proxy. I've debugged this before - it's time consuming, but you can add the meteor spiderable package source into your packages and debug from there. I'm going to close this as I don't think this is reaction specific, but a spiderable issue.

@aaronjudd
Copy link
Contributor

I forgot to mention that I published a "ongoworks:spiderable" package, that handles some of the proxy issues that I've encountered in docker deployments, but i'd almost be surprised if that worked since I haven't tested it with a release in a while.

@kifirkin
Copy link
Contributor

kifirkin commented Aug 4, 2015

I've just tested it at reactioncommerce demo site, and I've got Internal server error

@aaronjudd
Copy link
Contributor

I don't think the demo reaction sites have spiderable installed, or at least not ongoworks:spiderable... however reactioncommerce.com itself is using ongoworks:spiderable,

see: https://reactioncommerce.com/?_escaped_fragment_=

@kifirkin
Copy link
Contributor

kifirkin commented Aug 4, 2015

Oh I see , thanks I'll check it out later a bit more deeper

@kifirkin
Copy link
Contributor

kifirkin commented Sep 4, 2015

I've spent many hours trying to figure out what is going wrong with phantomjs and spiderable, but with no luck 😟

I found disscussion here iron-router#1192

I think I would try to use meteorhacks/meteor-ssr for seo, cause it is more native and lightweight solution

@chaksaray
Copy link

chaksaray commented Jun 7, 2016

I have the same problem as @gouthamve,, I spend long time, but i didn't get it fixed,,, very annoyed me.
Anyone get it workaround, please help guide me.

@brent-hoover
Copy link
Collaborator

@chaksaray I've opened a new issue here: #1063 because that original issue is over a year old. Could you please let me know what you have tried and what your current environment is?

cmbirk pushed a commit to cmbirk/reaction that referenced this issue Aug 18, 2019
…feat-product-import-editable-gsiOpType

Add gsiOpType to operator UI for products
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants