Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .env file #4706

Closed
aldeed opened this issue Oct 3, 2018 · 0 comments
Closed

Use .env file #4706

aldeed opened this issue Oct 3, 2018 · 0 comments
Assignees
Milestone

Comments

@aldeed
Copy link
Contributor

aldeed commented Oct 3, 2018

Most other projects in the Reaction ecosystem now use a .env file for ENV variables that need to be set. They include a committed .env.example file, which is copied to a gitignored .env before building.

Work

  1. Update the installation instructions in the public docs to document how environment variables work in the API project.
  2. Create a .env.example file and .env file. Add all variables that are currently in the environment section of docker-compose.yml
  3. Add .env to .gitignore
  4. Remove the environment section from docker-compose.yml and replace with:
    env_file:
      - ./.env
    
  5. Add pre-build project hook that creates/updates the .env file, the same as the script in the other repos. Note, however, that it cannot be in bin/setup because of Meteor's eager loading. It should be in .reaction/scripts.
@aldeed aldeed added this to the Oxford milestone Oct 3, 2018
@spencern spencern removed this from the Oxford milestone Oct 18, 2018
@aldeed aldeed self-assigned this Nov 25, 2018
@aldeed aldeed added this to the Redcloud milestone Nov 25, 2018
@spencern spencern closed this as completed Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants