Deploy release branches to staging ECS environment #4758
Conversation
…out for now for testing purposes)
.circleci/bin/ecs-deploy.sh
Outdated
| mkdir -p ~/.aws | ||
| echo "[default]" > ~/.aws/credentials | ||
| echo "aws_access_key_id = ${AWS_ACCESS_KEY_ID}" >> ~/.aws/credentials | ||
| echo "aws_secret_access_key = ${AWS_SECRET_ACCESS_KEY}" >> ~/.aws/credentials |
There was a problem hiding this comment.
@griggheo Just curious, why write these to a file when AWS lib typically already looks for env variables with these names? Seems more secure to avoid any credentials in files.
There was a problem hiding this comment.
It didn't work for me when I specified the AWS keys without actually writing them to the credentials file. I'll try again. Agreed it's better not to save them to disk.
| - container_port: 3000 | ||
| host_port: 3000 | ||
| image: reactioncommerce/reaction | ||
| image_tag: release-2.0.0-rc.5 |
There was a problem hiding this comment.
So this will need to be updated every time we make a new release branch?
There was a problem hiding this comment.
The image_tag is used only if you deploy using propel from the command line. CircleCI deployments will automatically use the SHA1 of the newly built Docker image.
| @@ -2,7 +2,7 @@ | |||
| .fileStorage/ | |||
| .vscode | |||
| .idea | |||
| .env | |||
| .env* | |||
There was a problem hiding this comment.
There's an open issue to add a .env file for this repo for local development, and that will involve creating a file named .env.example which will need to be committed (same pattern as in other repos). Can you change this ignore rule so that .env.example will be committed when we add that?
.circleci/config.yml
Outdated
| # only: /^release-2\.0.\d+$/ | ||
| filters: | ||
| branches: | ||
| only: /^release*/ |
There was a problem hiding this comment.
Were we going to do /^release-2*/ instead? There is currently a release-1.17.0 branch and could at some point be release-1.17.1. Should branches like that overwrite staging deployment?
cc @spencern
There was a problem hiding this comment.
OK I'll change it to /^release-2.*/ for now.
| - name: ROOT_URL | ||
| - name: HYDRA_ADMIN_URL | ||
| - name: HYDRA_OAUTH2_INTROSPECT_URL | ||
| - name: SKIP_FIXTURES |
There was a problem hiding this comment.
Does this list need to change when we add env variables? Where do the values come from? Maybe we can make this more straightforward when we do #4706
There was a problem hiding this comment.
Those are there for informational purposes only. I can remove them once we have the .env.example file.
|
Seems to work - I'm seeing an issue where prices on the grid are displaying without a currency symbol, but I doubt that is unique to this deployment.
|
…nches vs feature branches
|
@aldeed I think I've addressed all your requests. Please take a look when you have a chance. Thanks! |
|
This LGTM if you approve, @spencern. The app tests failed with a strange error, so I reran them. If they fail again, may need to investigate whether there is something in this PR that is causing it. |
Type: feature
Issue
We want to be able to test code in a release branch in a staging environment.
Solution
This PR uses the latest version of the propel CLI tool and a single propel.yaml manifest file to deploy the Docker image built in CircleCI to a staging environment in ECS. The data set used for the Reaction service is the 'dev' dataset hosted on a MongoDB server running on an EC2 instance in the staging environment.
Testing