-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.0 rc.6 #4755
Merged
Merged
Release 2.0.0 rc.6 #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out for now for testing purposes)
…rce/reaction into feat-4730-dancastellon-email-appevents
…eparate check for marketplace.
…what was already present.
…17-payment-methods-migration
…rce/reaction into feat-4727-dancastellon-primaryShop-query
…m:reactioncommerce/reaction into chore-pete-skip-failing-integration-tests
…meteor Update to base image 1.8
…ods-migration Added migration for adding available payment methods to shops.
…yment-methods Feat 4719 client ui payment methods
…rce/reaction into feat-4730-dancastellon-email-appevents
…-email-appevents feat: decouple SMTP email sending logic from core to allow plugins to override
….js so that tests in custom plugins w/ package.json files work
…nches vs feature branches
…jest-tests-plugins-w-package-json Fix: Import Babel config from package.json and export in babel.config.js to fix Jest tests in custom plugins that have a package.json
…-view-styles fix: keep toggles shown, width 100% in action view
SMS configuration secrets could be shared with unauthenticated users via the SmsSettings publication. If you use or have used the SMS plugin for Reaction Commerce, you should update your version immediately. Invalidate all existing SMS provider secrets which have been used with Reaction Commerce and generate new secrets for use going forward.
Dashboard routes would be rendered for unauthenticated users who directly enter a url. This commit fixes that issue.
…ntainers Deploy release branches to staging ECS environment
kieckhafer
previously requested changes
Nov 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kieckhafer
dismissed
their stale review
November 14, 2018 23:19
Issue not present in current version of branch
kieckhafer
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.0.0-rc.6
This is our sixth release candidate for v2.0.0 of Reaction. Please check it out and let us know what works and what doesn't for you.
Meteor 1.8 Final
We've been using a release candidate of Meteor 1.8 in all of our 2.0 release candidates to this point - this has also included release candidate versions of Babel 7. In this release we're updating to the final version of Meteor 1.8 and Babel 7.
There are a lot of great updates that are included in Meteor 1.8 and you can read all about them in the Meteor blog. I think the one that we'll notice the most is significant improvement to build performance that. We've been focused on improving the performance and developer experience with Reaction for a while now and this update makes significant progress towards improving the developer experience and build times. Anyone who's been using Reaction for a while should notice big improvements to the amount of time it takes for the app to rebuild after making changes.
We're still working with Node.js 8.11.4 as the upgrade to Node 8.12.0 got postponed to the Meteor 1.8.1 release. If you're itching to play with it, you can run
meteor update --release 1.8.1-beta.n
from the directory that you've got the corereaction
project installed. There may be some additional speed improvements related to Meteor's use ofFiber
s that come along in this version.We've also updated the our base docker image to use Meteor 1.8 (#4760)
Email Sending
We've extracted the core email sending functionality into a new
reaction-email-smtp
plugin which isincluded
and created a newsendEmail
event which is emitted for each email job. The core smtp email plugin now listens for these events and sends an email if an SMTP provider is configured. By doing this we've made it possible to create plugins which send emails via an API rather than via SMTP.The email provider config form found at Dashboard -> Emails -> Mail Provider is now also able to be overridden. Plugins can use register.js to provide a React component to use here.
GraphQL API
Added a primaryShop GraphQL query & resolver, eliminating the need to first query for the primary shop ID, followed by another query for shop by ID.
Breaking Changes
In #4749 we changed the names of our included payment method plugins. We've included a migration to automatically update any existing installation, but if you have custom code that relies on these payment method names you may need make some changes.
Fixes
Features
Migrations
Chores
We've been ignoring some of our integration tests as the in-memory MongoDB they rely on has not been working effectively. Previously we did this by skipping our entire
test:integration
tests in CI, we're now just skipping the tests that are failing due to this db incompatibility and have plans to address this soon.