Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skip failing integration tests #4751

Merged
merged 4 commits into from
Oct 18, 2018

Conversation

focusaurus
Copy link
Contributor

Impact: minor
Type: chore

Issue

Integration tests are failing with a mongo issue.

Solution

Skip the tests until @aldeed has a chance to investigate. I'll file a separate issue to track the broken tests.

@focusaurus focusaurus added the chore For issues that describe a task that does not affect the release, such as tests or CI configuration label Oct 17, 2018
@focusaurus focusaurus self-assigned this Oct 17, 2018
@focusaurus focusaurus requested a review from spencern October 17, 2018 15:49
@aldeed
Copy link
Contributor

aldeed commented Oct 17, 2018

@focusaurus I already updated the npm test command in rc5 so you'll also have to put integration tests back there. At this point, if you rebase this on rc6 branch and fix conflicts, that should do it.

@aldeed aldeed changed the base branch from master to release-2.0.0-rc.6 October 17, 2018 15:57
@focusaurus
Copy link
Contributor Author

OK I think this should be good to merge. Now we get through all the tests cleanly just the integration ones get skipped via jest.

@spencern
Copy link
Contributor

Looks good to me. Do we have a CI step we can re-enable now that they are skipped?

@focusaurus
Copy link
Contributor Author

I think it's the samenpm test step, just now the integration tests are part of that, but skipped.

@aldeed
Copy link
Contributor

aldeed commented Oct 18, 2018

Integration tests have never run on CI because of a different issue. Both @jeffcorpuz and I tried getting them to work on CI but gave up. At some point we may have to re-evaluate the way the in-memory MongoDB is used.

@aldeed aldeed merged commit a93c46e into release-2.0.0-rc.6 Oct 18, 2018
@aldeed aldeed deleted the chore-pete-skip-failing-integration-tests branch October 18, 2018 22:32
@spencern spencern mentioned this pull request Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants