feat: GraphQL query & resolver for loading the primary shop #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce/reaction into feat-4727-dancastellon-primaryShop-query
aldeed
previously requested changes
Oct 17, 2018
| export default async function primaryShopId(_, __, context) { | ||
| const shopId = await context.queries.primaryShopId(context.collections); | ||
| const shop = await context.queries.shopById(context, shopId); | ||
| return shop; |
There was a problem hiding this comment.
This is nice and simple, but it does two Shops.findOne calls when we often could do just one. You can make a separate primaryShop query function that does:
const domain = url.parse(context.rootUrl).hostname;
let shop = await Shops.findOne({ domains: domain });
if (!shop) {
shop = await Shops.findOne({ shopType: "primary" });
}
return shop;And then call that in this resolver
| * @param {Object} parentObject - unused | ||
| * @param {Object} args - unused | ||
| * @param {Object} context - an object containing the per-request state | ||
| * @return {Promise<o>} The shop, based on the domain in ROOT_URL |
| * @param {Object} context - an object containing the per-request state | ||
| * @return {Promise<o>} The shop, based on the domain in ROOT_URL | ||
| */ | ||
| export default async function primaryShopId(_, __, context) { |
There was a problem hiding this comment.
Function name should be primaryShop
aldeed
approved these changes
Oct 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4727
Impact: minor
Type: feature
Solution
This PR adds a
primaryShopGraphQL query & resolver, eliminating the need to first query for the primary shop ID, followed by another query for shop by ID.Breaking changes
None
Testing