Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create migration for old discount #6784

Merged
merged 3 commits into from
Feb 13, 2023
Merged

feat: create migration for old discount #6784

merged 3 commits into from
Feb 13, 2023

Conversation

vanpho93
Copy link
Member

@vanpho93 vanpho93 commented Feb 8, 2023

Resolves #6690
Impact: major
Type: feature

Issue

Old discount codes will not work in new promotion framework

Solution

Create migration for carts / discount codes to new promotions / coupons

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f2a2321

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vanpho93 vanpho93 requested a review from brent-hoover February 8, 2023 01:59
@vanpho93 vanpho93 force-pushed the feat/create-migration-for-old-discount branch from d16e979 to c4d5dca Compare February 9, 2023 00:29
brent-hoover
brent-hoover reviewed Feb 9, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
brent-hoover
brent-hoover requested changes Feb 9, 2023
View reviewed changes
packages/api-plugin-promotions-coupons/migrations/2.js
* @param {String} entity - The entity (normally a collection) that you are tracking the ID for
* @return {Promise<Number>} - The auto-incrementing ID to use
*/
async function incrementSequence(db, shopId, entity) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a function defined in the code already for this, we should not duplicate it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defined function is in another plugin, and we only have access to ({ db, progress }) so it's not easy to do.

packages/api-plugin-promotions-coupons/migrations/2.js Outdated Show resolved Hide resolved
packages/api-plugin-promotions-coupons/migrations/migrationsNamespace.js Show resolved Hide resolved
@vanpho93
feat: create migration for old discoupon
f18b2e8 
Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93
fix: add migration down method
919caa1 
Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93 vanpho93 force-pushed the feat/create-migration-for-old-discount branch from 6edbcf2 to 919caa1 Compare February 9, 2023 09:12
@vanpho93
fix: migration up error
f2a2321 
Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93 vanpho93 force-pushed the feat/create-migration-for-old-discount branch from 4c6814b to f2a2321 Compare February 13, 2023 07:07
@brent-hoover brent-hoover merged commit 93381c5 into feat/coupons Feb 13, 2023
@brent-hoover brent-hoover deleted the feat/create-migration-for-old-discount branch February 13, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brent-hoover brent-hoover brent-hoover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanpho93 @brent-hoover