fix: duplicatePromotion endpoint issue

[vannguyenn]

• Use insertedId instead of insertedCount for success check
• The response from insertOne doesn't include the insertedCount property

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9aa30d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vanpho93]

We are using many insertedCount in other places, this issue could relate to mongodb upgrade so I think I will work on it.

[brent-hoover]

@vannguyenn @vanpho93 What was the outcome of this? If we think we have uncovered another issue can we create a ticket to track the work? I think Chloe's fix is still legit for this particular problem?

[vanpho93]

@zenweasel the issue fixed here, just wait to merge to trunk
https://github.com/reactioncommerce/reaction/pull/6739/files#diff-76fff9e095f44a85888aae647be81d11e4001f0cc01ffdba2c0e20d839484bc5

[brent-hoover]

@vanpho93 Providing backwards compatibility is good, but shouldn't any new code use the updated API i.e. use insertedId?

[vanpho93]

@vanpho93 Providing backwards compatibility is good, but shouldn't any new code use the updated API i.e. use insertedId?

Yes, you're right, I think this PR is good to go.

[brent-hoover]

Thanks for the fix @vannguyenn