Skip §2.13 for value types #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcpiechura
force-pushed
the
skip_null_tests_for_value_types
branch
from
94c3bf8 to
de71fb1
Compare
akarnokd
reviewed
Mar 31, 2017
| @@ -5,21 +5,21 @@ | |||
| namespace Reactive.Streams.Example.Unicast.Tests | |||
| { | |||
| [TestFixture] | |||
| public class SyncSubscriberWhiteboxTest : SubscriberWhiteboxVerification<int?> | |||
| public class SyncSubscriberWhiteboxTest : SubscriberWhiteboxVerification<int> | |||
There was a problem hiding this comment.
I'd copy this test and keep both.
|
@akarnokd addressed your remark |
akarnokd
approved these changes
Apr 1, 2017
|
Fantastic! |
ktoso
reviewed
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #29
cc @akarnokd