Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GroupOnObservable emits too many changesets #851

Closed
dwcullop opened this issue Feb 12, 2024 · 1 comment · Fixed by #863
Closed

[Bug]: GroupOnObservable emits too many changesets #851

dwcullop opened this issue Feb 12, 2024 · 1 comment · Fixed by #863
Assignees
Labels

Comments

@dwcullop
Copy link
Member

Describe the bug 🐞

While the operator minimizes the number of group changesets, it doesn't try to reduce the number of changesets emitted by the Group Caches.

For example, if the source provides a changeset with 9 Additions such that it should be split into 3 groups of 3, then the group observable will emit a single changeset to add 3 groups, but each of the groups would emit a 3 changesets with 1 add each (for a total of 10 changesets).

Step to reproduce

Any use of the GroupOnObservable will exhibit this behavior.

Reproduction repository

https://github.com/dwcullop/DynamicData

Expected behavior

There should only be 4 total changesets emitted. One to add the 3 groups and then each group should emit a single changeset with all 3 adds together.

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

DynamicData Version

No response

Additional information ℹ️

No response

@dwcullop dwcullop added the bug label Feb 12, 2024
@dwcullop dwcullop self-assigned this Feb 12, 2024
dwcullop added a commit that referenced this issue Feb 22, 2024
…eSet (#863)

Fixes #851 by leveraging the code from #852 to suspend the notifications about changes to the group contents until all of the groups have been updated.
Copy link

github-actions bot commented Mar 8, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant