Sqlite3 provider doesn't include CreatedAt in selects #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this GetCreatedAt breaks for Sqlite3 backed caches.
|
Looks good, gonna wait till build turns green then hit the button |
|
Screw you 🔴 CI status this works just fine without you |
anaisbetts
pushed a commit
that referenced
this pull request
Aug 28, 2014
Sqlite3 provider doesn't include CreatedAt in selects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserting a cache item using the sqlite3 provider accurately sets CreatedAt on the row but the select operation doesn't include it with the net effect that GetCreatedAt is broken for sqlite3 backed caches.
This adds a test to verify and a fix for the problem.