Fix vacuum #214
Merged
Fix vacuum #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't have multiple statements in a prepared statement so the vacuum command was never been executed. This splits it into two statements that are run sequentially. Problem number two is that the vacuum command can't be run in a transaction[1] so we commit the transaction right before the vacuum and then start it up again after. This will very likely have unintended side-effects but it's a proof that this is what's going on. 1. https://sqlite.org/lang_vacuum.html
|
@paulcbetts How does this look to you? |
|
👍, into it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vacuum is broken in Akavache.Sqlite3 most likely going back to 4.0.0. There's two issues at play.
One is that you can't have multiple statements in a prepared statement so the
VACUUMstatement was never been executed, only theDELETE. Second, theVACUUMstatement can't be run within a transaction which is a problem since Akavache wraps everything in a transaction.This is a first PoC solution which splits the vacuum operation into two statements that are run sequentially. Because of the transaction limitation we commit the transaction right the vacuum and then start it up again after. This will very likely have unintended side-effects but it's a proof that this is what's going on.