Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents caches that were never used being created as side effect of BlobCache.Shutdown() #243

Merged
merged 4 commits into from
Sep 8, 2015

Conversation

jcomtois
Copy link
Contributor

Fixes issue #192.

Adding a null "ShutdownBlobCache" that can be used to prevent caches that were never used from being created upon BlobCache.Shutdown(). I set a static bool when Shutdown is called, then add a check of that bool to the null coalescing chain before a new instance would be created.

Please be kind, this is my first pull request on any project EVER.

}

IObservable<Unit> IBlobCache.Shutdown
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the indents here and on the other property declarations, so it looks like:

int Foo { 
  get { return 5; } 
}

@anaisbetts
Copy link
Member

Hey @jcomtois, this is a very good first PR! Make an extra commit or two to your branch to fix up these little things and I'll hit the merge. You don't need to close / resubmit on GitHub, just add extra commits to your branch

@jcomtois
Copy link
Contributor Author

jcomtois commented Sep 8, 2015

Thanks, @paulcbetts. Let me know if there are any more tweaks required. I'm a heavy user of ReactiveUI and Splat and just starting to use Akavache so I'm pleased that I can make a contribution back when your stuff has definitely made my life easier.

anaisbetts added a commit that referenced this pull request Sep 8, 2015
Prevents caches that were never used being created as side effect of BlobCache.Shutdown()
@anaisbetts anaisbetts merged commit 9092daf into reactiveui:master Sep 8, 2015
@anaisbetts
Copy link
Member

Thanks @jcomtois!

@jcomtois jcomtois deleted the jcomtois/shutdown-issue-192 branch September 8, 2015 16:38
@ghuntley ghuntley modified the milestone: 5.0.0 Nov 4, 2016
@ghuntley ghuntley added the Bug label Nov 4, 2016
@ghuntley ghuntley modified the milestone: 5.0.0 Nov 4, 2016
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants