use SQLitePCL.Batteries_V2.Init() instead of the original #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit(). the new one does exactly the same thing, but supports bait-and-switch across bundle types, which eases difficulties that can happen when using multiple libraries that use SQLitePCL.raw.
|
Not sure my commit message follows the guidelines. Feel free to tell me I need to redo this and be more careful. |
|
Bottom line here is that this change is not urgent, so no need to rush and release a new package on nuget. I'm just trying to steer everybody toward Batteries_V2.Init(). |
ghuntley
suggested changes
Jan 16, 2017
|
Updating the package dependencies is not necessary. The nuspec file here indicates it is using my version 1.1.0, which is the minimum needed for Batteries_V2. If you want to update the dependency to a more recent version, you can, and it should cause no problems, but it should not be necessary for this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batteries.Init(). the new one does exactly the same thing, but supports bait-and-switch across bundle types, which eases difficulties that can happen when using multiple libraries that use SQLitePCL.raw.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix (more or less)
What is the current behavior? (You can also link to an open issue here)
call SQLitePCL.Batteries.Init()
What is the new behavior (if this is a feature change)?
call SQLitePCL.Batteries_V2.Init()
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
Other information: