Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Update nullability annotations #668

Merged
merged 18 commits into from
Apr 11, 2021
Merged

Conversation

worldbeater
Copy link
Contributor

What kind of change does this PR introduce?

This PR updates nullability annotations in SQLite persistent blob cache, and picks dependabot deps.

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #668 (b45b66b) into main (0df080e) will increase coverage by 0.79%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   56.65%   57.44%   +0.79%     
==========================================
  Files          58       58              
  Lines        3472     3464       -8     
==========================================
+ Hits         1967     1990      +23     
+ Misses       1505     1474      -31     
Impacted Files Coverage Δ
src/Akavache.Drawing/BitmapImageMixin.cs 0.00% <0.00%> (ø)
....Sqlite3/SqlLiteCache/SqlRawPersistentBlobCache.cs 82.63% <ø> (-0.26%) ⬇️
src/Akavache.Core/BlobCache/BlobCache.cs 31.66% <100.00%> (+5.00%) ⬆️
src/Akavache.Core/HttpMixinExtensions.cs 100.00% <100.00%> (+50.00%) ⬆️
...e.Sqlite3/SqlLiteCache/SQLiteEncryptedBlobCache.cs 69.23% <100.00%> (+2.56%) ⬆️
src/Akavache.Sqlite3/Registrations.cs 83.33% <0.00%> (+25.00%) ⬆️
...atforms/shared-not-uwp/SimpleFilesystemProvider.cs 77.77% <0.00%> (+77.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df080e...b45b66b. Read the comment docs.

@worldbeater worldbeater marked this pull request as ready for review April 4, 2021 10:40
@worldbeater worldbeater marked this pull request as draft April 11, 2021 20:41
@worldbeater worldbeater marked this pull request as ready for review April 11, 2021 22:28
@glennawatson glennawatson merged commit 9ee4fe4 into main Apr 11, 2021
@glennawatson glennawatson deleted the nullability-fix branch April 11, 2021 23:14
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants