Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Cleanup syntax #789

Merged
merged 1 commit into from
Jun 25, 2022
Merged

housekeeping: Cleanup syntax #789

merged 1 commit into from
Jun 25, 2022

Conversation

glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Jun 25, 2022

fix: public api tests

What kind of change does this PR introduce?

Cleanup with newer C# syntax.
Fix up the public API tests

What is the current behavior?

Should be the same with different syntax

What is the new behavior?

Using refactor tools clean up the API

What might this PR break?

If the cleanup tools fail.

fix: public api tests
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #789 (0d04cee) into main (3bfd740) will increase coverage by 0.11%.
The diff coverage is 60.37%.

@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   57.44%   57.55%   +0.11%     
==========================================
  Files          58       58              
  Lines        3464     3367      -97     
==========================================
- Hits         1990     1938      -52     
+ Misses       1474     1429      -45     
Impacted Files Coverage Δ
src/Akavache.Core/LoginInfo.cs 0.00% <0.00%> (ø)
src/Akavache.Core/LoginMixin.cs 0.00% <0.00%> (ø)
src/Akavache.Core/MD5.cs 0.00% <0.00%> (ø)
src/Akavache.Core/Platforms/shared/MD5Managed.cs 0.00% <0.00%> (ø)
...rc/Akavache.Core/Platforms/shared/Registrations.cs 92.85% <ø> (ø)
src/Akavache.Core/Platforms/shared/StreamMixins.cs 0.00% <ø> (ø)
src/Akavache.Core/PreserveAttribute.cs 0.00% <0.00%> (ø)
src/Akavache.Core/RelativeTimeMixin.cs 0.00% <0.00%> (ø)
src/Akavache.Drawing/BitmapImageMixin.cs 0.00% <0.00%> (ø)
src/Akavache.Sqlite3/SqlLiteCache/SqlLite.cs 0.00% <0.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6406b4b...0d04cee. Read the comment docs.

@glennawatson glennawatson merged commit 3886ccb into main Jun 25, 2022
@glennawatson glennawatson deleted the glennawatson/update/code branch June 25, 2022 08:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant