Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Set Access Modifier for [Reactive] #67

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Feature
Closes #64

What is the current behavior?

All [Reactive] generated properties have public accessors

What is the new behavior?

[Reactive] generated properties can choose the 'set' access modifier definition

What might this PR break?

none

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Example of use [Reactive(SetModifier = AccessModifier.Protected)]

@ChrisPulman ChrisPulman merged commit 0910397 into main Sep 27, 2024
1 check passed
@ChrisPulman ChrisPulman deleted the CP_FixFor64AccessorAccess branch September 27, 2024 21:58
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: access modifier for set method for ReactiveAttribute
1 participant