Feature : Change Newtonsoft.Json to System.Text.Json (#3562)

<!-- Please be sure to read the
[Contribute](https://github.com/reactiveui/reactiveui#contribute)
section of the README -->

**What kind of change does this PR introduce?**
<!-- Bug fix, feature, docs update, ... -->

Feature #3190 

**What is the current behaviour?**
<!-- You can also link to an open issue here. -->

No support for System.Text.Json

**What is the new behaviour?**
<!-- If this is a feature change -->

System.Text.Json support for Serialization added

https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft?pivots=dotnet-7-0

**What might this PR break?**

If other Serializers are used verification of correct serialisation
should be confirmed

**Please check if the PR fulfills these requirements**
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

**Other information**:

.editorconfig

@@ -296,7 +296,7 @@ dotnet_diagnostic.SA1006.severity = error
 dotnet_diagnostic.SA1007.severity = error
 dotnet_diagnostic.SA1008.severity = error
 dotnet_diagnostic.SA1009.severity = error
-dotnet_diagnostic.SA1010.severity = error
+dotnet_diagnostic.SA1010.severity = suggestion
 dotnet_diagnostic.SA1011.severity = error
 dotnet_diagnostic.SA1012.severity = error
 dotnet_diagnostic.SA1013.severity = error
@@ -525,3 +525,5 @@ indent_size = 2
 end_of_line = lf
 [*.{cmd, bat}]
 end_of_line = crlf
+
+vsspell_dictionary_languages = en-US

src/Directory.build.props

@@ -13,10 +13,11 @@
     <DefaultPackageDescription>A MVVM framework that integrates with the Reactive Extensions for .NET to create elegant, testable User Interfaces that run on any mobile or desktop platform. Supports Xamarin.iOS, Xamarin.Android, Xamarin.Mac, Xamarin Forms, Xamarin.TVOS, Tizen, WPF, Windows Forms, Universal Windows Platform (UWP) and the Uno Platform.</DefaultPackageDescription>
     <PackageDescription>$(DefaultPackageDescription)</PackageDescription>
     <Owners>xanaisbettsx;ghuntley</Owners>
-    <PackageTags>mvvm;reactiveui;rx;reactive extensions;observable;LINQ;events;frp;xamarin;android;ios;mac;forms;monodroid;monotouch;xamarin.android;xamarin.ios;xamarin.forms;xamarin.mac;xamarin.tvos;wpf;net;netstandard;net461;uwp;tizen;unoplatform</PackageTags>
+    <PackageTags>mvvm;reactiveui;rx;reactive extensions;observable;LINQ;events;frp;xamarin;android;ios;mac;forms;monodroid;monotouch;xamarin.android;xamarin.ios;xamarin.forms;xamarin.mac;xamarin.tvos;wpf;net;netstandard;net462;winui;maui;tizen;unoplatform</PackageTags>
     <PackageReleaseNotes>https://github.com/reactiveui/ReactiveUI/releases</PackageReleaseNotes>
     <RepositoryUrl>https://github.com/reactiveui/reactiveui</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
+    <NoWarn>$(NoWarn);VSSpell001</NoWarn>
 
     <!-- Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
     <PublishRepositoryUrl>true</PublishRepositoryUrl> 
@@ -33,6 +34,9 @@
     <IncludePackageReferencesDuringMarkupCompilation>true</IncludePackageReferencesDuringMarkupCompilation>
     <PublishRepositoryUrl>true</PublishRepositoryUrl> 
   </PropertyGroup>
+  <PropertyGroup Condition="$(IsTestProject) != 'true'">
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+  </PropertyGroup>
 
   <!-- MonoAndroid doesn't seem to want to allow debugging for maintainers -->
   <PropertyGroup Condition=" $(TargetFramework.StartsWith('MonoAndroid')) ">

src/ReactiveUI.AndroidSupport/ReactivePagerAdapter.cs

@@ -89,7 +89,7 @@ public override void DestroyItem(ViewGroup container, int position, Object item)
             throw new ArgumentNullException(nameof(item));
         }
 
-        if (!(item is View view))
+        if (item is not View view)
         {
             throw new ArgumentException("Item must be of type View", nameof(item));
         }

src/ReactiveUI.AndroidSupport/ReactiveRecyclerViewAdapter.cs

@@ -63,7 +63,7 @@ public override void OnBindViewHolder(RecyclerView.ViewHolder holder, int positi
             throw new ArgumentNullException(nameof(holder));
         }
 
-        if (!(holder is IViewFor viewForHolder))
+        if (holder is not IViewFor viewForHolder)
         {
             throw new ArgumentException("Holder must be derived from IViewFor", nameof(holder));
         }
@@ -133,4 +133,4 @@ protected ReactiveRecyclerViewAdapter(TCollection backingList)
         : base(backingList.ToObservableChangeSet<TCollection, TViewModel>())
     {
     }
-}
+}

src/ReactiveUI.AndroidSupport/ReactiveRecyclerViewViewHolder.cs

@@ -5,7 +5,7 @@
 
 using System.Reflection;
 using System.Runtime.Serialization;
-
+using System.Text.Json.Serialization;
 using Android.Support.V7.Widget;
 using Android.Views;
 
@@ -23,6 +23,7 @@ public class ReactiveRecyclerViewViewHolder<TViewModel> : RecyclerView.ViewHolde
     /// </summary>
     [SuppressMessage("StyleCop.CSharp.MaintainabilityRules", "SA1401: Field should be private", Justification = "Legacy reasons")]
     [IgnoreDataMember]
+    [JsonIgnore]
     protected Lazy<PropertyInfo[]> AllPublicProperties = null!;
 
     private readonly Subject<Unit> _activated = new();
@@ -92,30 +93,26 @@ protected ReactiveRecyclerViewViewHolder(View view)
 
     /// <summary>
     /// Gets an observable that signals that this ViewHolder has been selected.
-    ///
     /// The <see cref="int"/> is the position of this ViewHolder in the <see cref="RecyclerView"/>
     /// and corresponds to the <see cref="RecyclerView.ViewHolder.AdapterPosition"/> property.
     /// </summary>
     public IObservable<int> Selected { get; }
 
     /// <summary>
     /// Gets an observable that signals that this ViewHolder has been selected.
-    ///
     /// The <see cref="IObservable{TViewModel}"/> is the ViewModel of this ViewHolder in the <see cref="RecyclerView"/>.
     /// </summary>
     public IObservable<TViewModel?> SelectedWithViewModel { get; }
 
     /// <summary>
     /// Gets an observable that signals that this ViewHolder has been long-clicked.
-    ///
     /// The <see cref="int"/> is the position of this ViewHolder in the <see cref="RecyclerView"/>
     /// and corresponds to the <see cref="RecyclerView.ViewHolder.AdapterPosition"/> property.
     /// </summary>
     public IObservable<int> LongClicked { get; }
 
     /// <summary>
     /// Gets an observable that signals that this ViewHolder has been long-clicked.
-    ///
     /// The <see cref="IObservable{TViewModel}"/> is the ViewModel of this ViewHolder in the <see cref="RecyclerView"/>.
     /// </summary>
     public IObservable<TViewModel?> LongClickedWithViewModel { get; }
@@ -142,6 +139,7 @@ public TViewModel? ViewModel
     /// Gets an observable which signals when exceptions are thrown.
     /// </summary>
     [IgnoreDataMember]
+    [JsonIgnore]
     public IObservable<Exception> ThrownExceptions => this.GetThrownExceptionsObservable();
 
     /// <inheritdoc/>
@@ -153,10 +151,12 @@ public TViewModel? ViewModel
 
     /// <inheritdoc/>
     [IgnoreDataMember]
+    [JsonIgnore]
     public IObservable<IReactivePropertyChangedEventArgs<ReactiveRecyclerViewViewHolder<TViewModel>>> Changing => this.GetChangingObservable();
 
     /// <inheritdoc/>
     [IgnoreDataMember]
+    [JsonIgnore]
     public IObservable<IReactivePropertyChangedEventArgs<ReactiveRecyclerViewViewHolder<TViewModel>>> Changed => this.GetChangedObservable();
 
     /// <inheritdoc/>

src/ReactiveUI.AndroidX/ReactivePagerAdapter.cs

@@ -91,7 +91,7 @@ public override void DestroyItem(ViewGroup container, int position, Object item)
             throw new ArgumentNullException(nameof(item));
         }
 
-        if (!(item is View view))
+        if (item is not View view)
         {
             throw new ArgumentException("Item must be of type View", nameof(item));
         }

src/ReactiveUI.AndroidX/ReactiveRecyclerViewAdapter.cs

@@ -61,7 +61,7 @@ public override void OnBindViewHolder(RecyclerView.ViewHolder holder, int positi
             throw new ArgumentNullException(nameof(holder));
         }
 
-        if (!(holder is IViewFor viewForHolder))
+        if (holder is not IViewFor viewForHolder)
         {
             throw new ArgumentException("Holder must be derived from IViewFor", nameof(holder));
         }

src/ReactiveUI.AndroidX/ReactiveRecyclerViewViewHolder.cs

@@ -5,7 +5,7 @@
 
 using System.Reflection;
 using System.Runtime.Serialization;
-
+using System.Text.Json.Serialization;
 using Android.Views;
 
 using AndroidX.RecyclerView.Widget;
@@ -26,6 +26,7 @@ public class ReactiveRecyclerViewViewHolder<TViewModel> : RecyclerView.ViewHolde
     [SuppressMessage("Design", "CA1051: Do not declare visible instance fields", Justification = "Legacy reasons")]
     [SuppressMessage("StyleCop.CSharp.MaintainabilityRules", "SA1306: Field should start with a lower case letter", Justification = "Legacy reasons")]
     [IgnoreDataMember]
+    [JsonIgnore]
     protected Lazy<PropertyInfo[]>? AllPublicProperties;
 
     private readonly Subject<Unit> _activated = new();
@@ -96,30 +97,26 @@ protected ReactiveRecyclerViewViewHolder(View view)
 
     /// <summary>
     /// Gets an observable that signals that this ViewHolder has been selected.
-    ///
     /// The <see cref="int"/> is the position of this ViewHolder in the <see cref="RecyclerView"/>
     /// and corresponds to the <see cref="RecyclerView.ViewHolder.AdapterPosition"/> property.
     /// </summary>
     public IObservable<int> Selected { get; }
 
     /// <summary>
     /// Gets an observable that signals that this ViewHolder has been selected.
-    ///
     /// The <see cref="IObservable{TViewModel}"/> is the ViewModel of this ViewHolder in the <see cref="RecyclerView"/>.
     /// </summary>
     public IObservable<TViewModel?> SelectedWithViewModel { get; }
 
     /// <summary>
     /// Gets an observable that signals that this ViewHolder has been long-clicked.
-    ///
     /// The <see cref="int"/> is the position of this ViewHolder in the <see cref="RecyclerView"/>
     /// and corresponds to the <see cref="RecyclerView.ViewHolder.AdapterPosition"/> property.
     /// </summary>
     public IObservable<int> LongClicked { get; }
 
     /// <summary>
     /// Gets an observable that signals that this ViewHolder has been long-clicked.
-    ///
     /// The <see cref="IObservable{TViewModel}"/> is the ViewModel of this ViewHolder in the <see cref="RecyclerView"/>.
     /// </summary>
     public IObservable<TViewModel?> LongClickedWithViewModel { get; }
@@ -146,6 +143,7 @@ public TViewModel? ViewModel
     /// Gets an observable which signals when exceptions are thrown.
     /// </summary>
     [IgnoreDataMember]
+    [JsonIgnore]
     public IObservable<Exception> ThrownExceptions => this.GetThrownExceptionsObservable();
 
     /// <inheritdoc/>
@@ -157,10 +155,12 @@ public TViewModel? ViewModel
 
     /// <inheritdoc/>
     [IgnoreDataMember]
+    [JsonIgnore]
     public IObservable<IReactivePropertyChangedEventArgs<ReactiveRecyclerViewViewHolder<TViewModel>>> Changing => this.GetChangingObservable();
 
     /// <inheritdoc/>
     [IgnoreDataMember]
+    [JsonIgnore]
     public IObservable<IReactivePropertyChangedEventArgs<ReactiveRecyclerViewViewHolder<TViewModel>>> Changed => this.GetChangedObservable();
 
     /// <inheritdoc/>

src/ReactiveUI.Blend/Platforms/net4/ObservableTrigger.cs

@@ -43,7 +43,7 @@ public IObservable<object> Observable
     /// <param name="e">The <see cref="DependencyPropertyChangedEventArgs"/> instance containing the event data.</param>
     protected static void OnObservableChanged(DependencyObject sender, DependencyPropertyChangedEventArgs e)
     {
-        if (!(sender is ObservableTrigger triggerItem))
+        if (sender is not ObservableTrigger triggerItem)
         {
             throw new ArgumentException("Sender must be of type " + nameof(ObservableTrigger), nameof(sender));
         }

src/ReactiveUI.Maui/ViewModelViewHost.cs

@@ -82,7 +82,7 @@ public ViewModelViewHost()
                         throw new Exception($"Couldn't find view for '{x.ViewModel}'.");
                     }
 
-                    if (!(view is View castView))
+                    if (view is not View castView)
                     {
                         throw new Exception($"View '{view.GetType().FullName}' is not a subclass of '{typeof(View).FullName}'.");
                     }

src/ReactiveUI.Tests/API/ApiApprovalTests.ReactiveUI.DotNet6_0.verified.txt

@@ -716,10 +716,13 @@ namespace ReactiveUI
     {
         public ReactiveObject() { }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IReactivePropertyChangedEventArgs<ReactiveUI.IReactiveObject>> Changed { get; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IReactivePropertyChangedEventArgs<ReactiveUI.IReactiveObject>> Changing { get; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<System.Exception> ThrownExceptions { get; }
         public event System.ComponentModel.PropertyChangedEventHandler? PropertyChanged;
         public event System.ComponentModel.PropertyChangingEventHandler? PropertyChanging;
@@ -742,10 +745,13 @@ namespace ReactiveUI
     {
         public ReactiveRecord() { }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IReactivePropertyChangedEventArgs<ReactiveUI.IReactiveObject>> Changed { get; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IReactivePropertyChangedEventArgs<ReactiveUI.IReactiveObject>> Changing { get; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<System.Exception> ThrownExceptions { get; }
         public event System.ComponentModel.PropertyChangedEventHandler? PropertyChanged;
         public event System.ComponentModel.PropertyChangingEventHandler? PropertyChanging;
@@ -800,17 +806,23 @@ namespace ReactiveUI
     {
         public RoutingState(System.Reactive.Concurrency.IScheduler? scheduler = null) { }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IRoutableViewModel> CurrentViewModel { get; set; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public ReactiveUI.ReactiveCommand<ReactiveUI.IRoutableViewModel, ReactiveUI.IRoutableViewModel> Navigate { get; set; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public ReactiveUI.ReactiveCommand<ReactiveUI.IRoutableViewModel, ReactiveUI.IRoutableViewModel> NavigateAndReset { get; set; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public ReactiveUI.ReactiveCommand<System.Reactive.Unit, ReactiveUI.IRoutableViewModel> NavigateBack { get; set; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<DynamicData.IChangeSet<ReactiveUI.IRoutableViewModel>> NavigationChanged { get; set; }
         [System.Runtime.Serialization.DataMember]
-        public System.Collections.ObjectModel.ObservableCollection<ReactiveUI.IRoutableViewModel> NavigationStack { get; }
+        [System.Text.Json.Serialization.JsonRequired]
+        public System.Collections.ObjectModel.ObservableCollection<ReactiveUI.IRoutableViewModel> NavigationStack { get; set; }
     }
     public static class RoutingStateMixins
     {

src/ReactiveUI.Tests/API/ApiApprovalTests.ReactiveUI.DotNet7_0.verified.txt

@@ -716,10 +716,13 @@ namespace ReactiveUI
     {
         public ReactiveObject() { }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IReactivePropertyChangedEventArgs<ReactiveUI.IReactiveObject>> Changed { get; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IReactivePropertyChangedEventArgs<ReactiveUI.IReactiveObject>> Changing { get; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<System.Exception> ThrownExceptions { get; }
         public event System.ComponentModel.PropertyChangedEventHandler? PropertyChanged;
         public event System.ComponentModel.PropertyChangingEventHandler? PropertyChanging;
@@ -742,10 +745,13 @@ namespace ReactiveUI
     {
         public ReactiveRecord() { }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IReactivePropertyChangedEventArgs<ReactiveUI.IReactiveObject>> Changed { get; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IReactivePropertyChangedEventArgs<ReactiveUI.IReactiveObject>> Changing { get; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<System.Exception> ThrownExceptions { get; }
         public event System.ComponentModel.PropertyChangedEventHandler? PropertyChanged;
         public event System.ComponentModel.PropertyChangingEventHandler? PropertyChanging;
@@ -800,17 +806,23 @@ namespace ReactiveUI
     {
         public RoutingState(System.Reactive.Concurrency.IScheduler? scheduler = null) { }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<ReactiveUI.IRoutableViewModel> CurrentViewModel { get; set; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public ReactiveUI.ReactiveCommand<ReactiveUI.IRoutableViewModel, ReactiveUI.IRoutableViewModel> Navigate { get; set; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public ReactiveUI.ReactiveCommand<ReactiveUI.IRoutableViewModel, ReactiveUI.IRoutableViewModel> NavigateAndReset { get; set; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public ReactiveUI.ReactiveCommand<System.Reactive.Unit, ReactiveUI.IRoutableViewModel> NavigateBack { get; set; }
         [System.Runtime.Serialization.IgnoreDataMember]
+        [System.Text.Json.Serialization.JsonIgnore]
         public System.IObservable<DynamicData.IChangeSet<ReactiveUI.IRoutableViewModel>> NavigationChanged { get; set; }
         [System.Runtime.Serialization.DataMember]
-        public System.Collections.ObjectModel.ObservableCollection<ReactiveUI.IRoutableViewModel> NavigationStack { get; }
+        [System.Text.Json.Serialization.JsonRequired]
+        public System.Collections.ObjectModel.ObservableCollection<ReactiveUI.IRoutableViewModel> NavigationStack { get; set; }
     }
     public static class RoutingStateMixins
     {