Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Unable to use activation of views on Windows with MAUI #3700

Closed
mwhapples opened this issue Dec 30, 2023 · 2 comments
Closed

[Bug]: Unable to use activation of views on Windows with MAUI #3700

mwhapples opened this issue Dec 30, 2023 · 2 comments
Labels
bug

Comments

@mwhapples
Copy link

Describe the bug 🐞

If I add a view which uses activation (eg. ViewModelViewHost) to a MAUI application then the application will fail with an exception on Windows. The exception is about not knowing how to activate the view and suggests implementing IActivationForViewFetcher. I have created an example project which can be found at https://github.com/mwhapples/ReactiveUIActivation

Step to reproduce

  1. Open the example project from https://github.com/mwhapples/ReactiveUIActivation
  2. Build and run on Windows
  3. Observe the Error
  4. Compare with running on other platform such as Android

Reproduction repository

https://github.com/mwhapples/ReactiveUIActivation

Expected behavior

App will load and the page will be shown

Screenshots 🖼️

No response

IDE

No response

Operating system

Windows

Version

No response

Device

No response

ReactiveUI Version

19.5.31

Additional information ℹ️

No response
@mwhapples mwhapples added the bug label Dec 30, 2023
ChrisPulman added a commit that referenced this issue Dec 31, 2023
@ChrisPulman
FIx for #3700
056711c 
Maui Activation updated to include all relevant types
@ChrisPulman ChrisPulman mentioned this issue Dec 31, 2023
Merged
2 tasks
ChrisPulman added a commit that referenced this issue Dec 31, 2023
@ChrisPulman
Fix for #3700 Maui Activation fails (#3703)
845fb4d 
<!-- Please be sure to read the
[Contribute](https://github.com/reactiveui/reactiveui#contribute)
section of the README -->

**What kind of change does this PR introduce?**
<!-- Bug fix, feature, docs update, ... -->

Fix for #3700 

**What is the current behavior?**
<!-- You can also link to an open issue here. -->

Maui Activation fails.

**What is the new behavior?**
<!-- If this is a feature change -->

Maui Activation updated to include all relevant types

**What might this PR break?**

none expected

**Please check if the PR fulfills these requirements**
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

**Other information**:
@ChrisPulman
Copy link
Member

This should be resolved with the next release, thank you for raising the issue.

@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mwhapples @ChrisPulman