feature: improved exception message when there are multiple resource IDs with the same name #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This clarifies the exception you get when
ControlFetcherMixin
collects the names of resource ID's in your layout files. It shows you for which ID's it's exactly failing so it's easier to find which names are the culprit.What is the current behavior? (You can also link to an open issue here)
When you have duplicate names with different casings in use as resource ID's, you get a fairly generic
ArgumentException
which is hard to understand without diving into the code ofControlFetcherMixin
.What is the new behavior (if this is a feature change)?
We throw a more explanatory
InvalidOperationException
which shows which names should be fixed to get things going.Does this PR introduce a breaking change?
Nope, unless someone is already catching the
ArgumentException
themselves, but I can't imagine anyone relying on such functionality.Please check if the PR fulfills these requirements
Other information:
As reported in #1275, and we ran into this ourselves as well. Cost multiple of our engineers a good couple of minutes to figure out what's wrong.