Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add the tizen30 platform to reactiveui #1387

Closed
wants to merge 6 commits into from
Closed

Conversation

ghuntley
Copy link
Member

@ghuntley ghuntley commented Jun 27, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

The Plan

  • Get a clean msbuild without referencing any Tizen platform specifics. (we are here; current attempts blocked at this stage)
  • Generate and package reactiveui-events for tizen30 via downloading packages from NuGet.
  • Start adding platform specific/public API surface to reactiveui

Other information:

Blocked until figure out how to multi-target the platform correctly:

Error message after 7e9535a

image

Error message after 2fb2ba4

image

AppVeyor does not have the tizen SDK's installed but I do on my local machine (obtained yesterday from https://developer.tizen.org/development/tizen-.net-preview/getting-started/installing-visual-studio-tools-tizen). All screenshots/logs are from my local machine.

/cc @WonyoungChoi

@clairernovotny
Copy link
Member

I added preliminary support for Tizen in the extras package. You'll need the CI feed for now:
https://www.myget.org/F/msbuildsdkextras/api/v3/index.json

It's 1.0.5-beta.51. Based on the way the Xamarin TFM's and all are structured, you'll likely need to do conditional PackageReference for the tizen30 TFM for the tizen specific packages you want/need since no one seems to be using the tizen30 tfm in their packages yet.

@clairernovotny
Copy link
Member

@ghuntley Tizen now will build correctly. What you need is to update the shared\Registrations.cs since there's nothing in there for Tizen.

There is a TIZEN and TIZEN3_0 symbol defined if you want to condition off of either of those.

@ghuntley
Copy link
Member Author

ghuntley commented Jul 9, 2017

Thanks for helping out here @onovotny.

@WonyoungChoi
Copy link

I am sorry to inform you late. Tizen .NET preview 4 has been released last week. Unfortunately, however, the Tizen TFM has not been used yet. I recommend making a seperated package for tizen and using netstandard for it until the Tizen TFM is ready. And please use Tizen.NET 3.0.0 instead of Tizen.Library. The Tizen.Library will not be managed anymore.

@clairernovotny
Copy link
Member

Thanks @WonyoungChoi, good to know. If it helps, I've added support for the Tizen TFM's in my MSBuild.Sdk.Extras package so that SDK-style projects can build them.

@clairernovotny
Copy link
Member

@WonyoungChoi The directions are here, https://github.com/onovotny/MSBuildSdkExtras/blob/master/README.md#using-the-package, and I'm happy to help any way I can.

@WonyoungChoi
Copy link

@onovotny Thank you for adding Tizen tfm to your package. :) It will help us a lot.

@clairernovotny
Copy link
Member

@WonyoungChoi it probably won't help with the application projects, since that requires support from your project system for debugging, but it "teaches" the SDK-style project system how to build class libraries that can target your platform. Please feel free to reach out to me anytime if you need help. My email is oren at novotny dot org.

@ghuntley
Copy link
Member Author

ghuntley commented Dec 7, 2017

Linking dotnet/corert#4856 in with this thread.

@rookiejava rookiejava mentioned this pull request Dec 7, 2017
2 tasks
@ghuntley
Copy link
Member Author

Replaced by #1546

@ghuntley ghuntley closed this May 17, 2018
@glennawatson glennawatson deleted the tizen30 branch August 4, 2018 00:14
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants