Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MAUI WinUI Schedulers #3306

Merged
merged 9 commits into from
Jul 8, 2022
Merged

Fix for MAUI WinUI Schedulers #3306

merged 9 commits into from
Jul 8, 2022

Conversation

ChrisPulman
Copy link
Member

@ChrisPulman ChrisPulman commented Jul 6, 2022

What kind of change does this PR introduce?

Fix for #3020

What is the current behaviour?

Maui WinUI does not have Schedulers set for RxApp Schedulers

What is the new behaviour?

Maui WinUI has a Scheduler set for RxApp.MainThreadScheduler and RxApp.TaskpoolScheduler
other WinUI registrations applied.

What might this PR break?

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #3306 (d8e8059) into main (a03e713) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3306      +/-   ##
==========================================
+ Coverage   63.83%   64.05%   +0.22%     
==========================================
  Files         157      157              
  Lines        5726     5726              
==========================================
+ Hits         3655     3668      +13     
+ Misses       2071     2058      -13     
Impacted Files Coverage Δ
...activeUI.Uwp/Common/AutoDataTemplateBindingHook.cs 95.00% <ø> (ø)
...eUI.Uwp/Common/BooleanToVisibilityTypeConverter.cs 70.58% <ø> (ø)
src/ReactiveUI.Uwp/Common/ReactivePage.cs 0.00% <ø> (ø)
src/ReactiveUI/RxApp.cs 81.94% <0.00%> (+6.94%) ⬆️
.../Converter/NullableIntegerToStringTypeConverter.cs 94.44% <0.00%> (+11.11%) ⬆️
src/ReactiveUI.Wpf/Registrations.cs 94.11% <0.00%> (+11.76%) ⬆️
src/ReactiveUI.Winforms/Registrations.cs 94.11% <0.00%> (+11.76%) ⬆️
.../ReactiveUI/Platforms/net/PlatformRegistrations.cs 85.71% <0.00%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03e713...d8e8059. Read the comment docs.

@glennawatson glennawatson merged commit 196b8a6 into main Jul 8, 2022
@glennawatson glennawatson deleted the CP_FixMauiWinUI branch July 8, 2022 01:23
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants