Fix stop oaph omitting inappropriately #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For deferred subscriptions in OAPH 2 changes where made: - On first `Value` access INPC is no longer emitted while the `Value` is still the initial value. - Before accessing `Value` for the first, INPC is no longer emitted if the value produced from source is the same as the initial value
|
Might be worth also adding some unit tests. You basically made them anyway in your original issue you made. |
|
@glennawatson Done! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3693 +/- ##
==========================================
- Coverage 58.38% 58.37% -0.01%
==========================================
Files 160 160
Lines 5774 5776 +2
Branches 1028 1029 +1
==========================================
+ Hits 3371 3372 +1
Misses 2015 2015
- Partials 388 389 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3682
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
For deferred subscriptions in OAPH 2 changes where made:
On first
Valueaccess INPC is no longer emitted while theValueis still the initial value.After accessing
Valuefor the first time, INPC is no longer emitted if the value produced from source is the same as the initial valueWhat might this PR break?
I don't think anything will break. It doesn't make sense for any UI framework to subscribe to INPC without reading the initial value anyway.
Please check if the PR fulfills these requirements
Other information: