Fix RxSchedulers not being set by ReactiveUI.Testing SchedulerExtensions #4184
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
approved these changes
Oct 14, 2025
|
I'll bump and release this weekend btw. I generally try and release on weekends when I can. |
|
Yep, all good. I unblocked myself locally with the workaround I described in the linked issue. Thanks @glennawatson :) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Fixes #4183
What is the current behavior?
When using SchedulerExtensions in ReactiveUI.Testing, the new RxSchedulers are not set correctly which fails tests.
What is the new behavior?
Now setting both RxApp schedulers and RxSchedulers in the extensions. Also added test coverage to ensure fixes are ok
What might this PR break?
Please check if the PR fulfills these requirements
Other information: