Make ExecuteAsync throw the original exception #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -374,7 +374,7 @@ public IObservable<T> ExecuteAsync(object parameter = null) | |||
| .Do(x => executeResults.OnNext(x)) | |||
| .Catch<T, Exception>(ex => { | |||
| exceptions.OnNext(ex); | |||
| return Observable.Empty<T>(); | |||
There was a problem hiding this comment.
We can nuke the Catch block here and just use the OnError clause of the Do above it
|
👍 |
|
@paulcbetts Fixed the catch! |
anaisbetts
pushed a commit
that referenced
this pull request
Jul 30, 2014
Make ExecuteAsync throw the original exception
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #685