(De)activation is not working in ReactiveWindowControler #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // notification to support (de)activation | ||
| NSNotificationCenter | ||
| .DefaultCenter | ||
| .AddObserver(NSWindow.WillCloseNotification, _ => deactivated.OnNext(Unit.Default)); |
There was a problem hiding this comment.
Doesn't this subscribe to any Window being closed? We only want to deactivate when this Window is being closed
There was a problem hiding this comment.
That is what I was thinking too. But it seems you can register for notifications from the current window according to the docs. https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/Notifications/Articles/Registering.html. Does AddObserver have another overload?
There was a problem hiding this comment.
Does this look right? @mteper can you give this a go?
NSNotificationCenter.DefaultCenter
.AddObserver(NSWindow.WillCloseNotification, _ => deactivated.OnNext(Unit.Default), this);If not we have to start registering selectors and shit to make this work :-/
…nly affects the given window.
|
Yup, you guys were right, I missed the filtering bit. Now corrected. Thanks! |
anaisbetts
pushed a commit
that referenced
this pull request
Aug 8, 2014
(De)activation is not working in ReactiveWindowControler
|
Thanks @mteper! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now listen for window is closing notifications and triggering deactivation.