Added support for binding to properties of Component (WinForms) #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
anaisbetts
pushed a commit
that referenced
this pull request
Sep 15, 2014
Added support for binding to properties of Component (WinForms)
|
Looks good, thanks @vanderkleij! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to my previous pull request. You can only bind one-way to properties of WinForms Components: the property will be set upon ViewModel changes, but no notifications are received for changes to the Component. This problem does not occur with Controls, because notifications are triggered for changes to Control properties correctly.
There are properties of Components that are very suitable for two-way binding however, such as ToolStripButton.Checked. This pull request remedies the problem by adding change nofications for properties of a Component.
The test WinformsCreatesObservableForPropertyWorksForComponents illustrates the problem. The one-word change to WinformsCreatesObservableForProperty makes the test pass.