Fixes NSInternalInconsistencyException on multiple sections update #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated in a table/collection view
| @@ -301,6 +313,52 @@ void resetupAll(IReadOnlyList<TSectionInfo> newSectionInfo) | |||
| adapter.ReloadData(); | |||
| })); | |||
|
|
|||
| disp.Add(sectionUpdatesSubject | |||
| .Buffer(TimeSpan.FromMilliseconds(125), RxApp.MainThreadScheduler) | |||
There was a problem hiding this comment.
Is there any way we can combine section and item updates? I know it'll make the code uglier, but every time we call Buffer we're kicking off timers, so we want to minimize how many we kick off
|
Looks good! Thanks @srimoyee-factory! |
anaisbetts
added a commit
that referenced
this pull request
Nov 6, 2014
Fixes NSInternalInconsistencyException on multiple sections update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a table/collection view with multiple sections and the data for more than one section changes at once, it causes an NSInternalInconsistencyException. This is because CommonReactiveSource calls PerformBatchUpdates on every updated section once, but the collection/tableview expects all the updates to be batched in one call to PerformBatchUpdates.
I have a manual test case where the crash can be reproduced and this patch fixes it (I can attach the manual test case here, but couldn't figure out how to do it).