Housekeeping fix some of the code analyser warnings (#1866)

InterfaceStubGenerator.Shared/InterfaceStubGenerator.cs

@@ -77,6 +77,15 @@ public void GenerateInterfaceStubs<TContext>(
             ImmutableArray<InterfaceDeclarationSyntax> candidateInterfaces
         )
         {
+            if (compilation == null)
+                throw new ArgumentNullException(nameof(compilation));
+
+            if (reportDiagnostic == null)
+                throw new ArgumentNullException(nameof(reportDiagnostic));
+
+            if (addSource == null)
+                throw new ArgumentNullException(nameof(addSource));
+
             refitInternalNamespace =
                 $"{refitInternalNamespace ?? string.Empty}RefitInternalGenerated";
 
@@ -131,7 +140,11 @@ ImmutableArray<InterfaceDeclarationSyntax> candidateInterfaces
                     m => m.ContainingType,
                     SymbolEqualityComparer.Default
                 )
-                .ToDictionary(g => g.Key, v => v.ToList());
+                .ToDictionary<IGrouping<INamedTypeSymbol, IMethodSymbol>, INamedTypeSymbol, List<IMethodSymbol>>(
+                    g => g.Key,
+                    v => [.. v],
+                    SymbolEqualityComparer.Default
+                );
 
             // Look through the candidate interfaces
             var interfaceSymbols = new List<INamedTypeSymbol>();
@@ -850,9 +863,9 @@ public void Initialize(GeneratorInitializationContext context)
 
         class SyntaxReceiver : ISyntaxReceiver
         {
-            public List<MethodDeclarationSyntax> CandidateMethods { get; } = new();
+            public List<MethodDeclarationSyntax> CandidateMethods { get; } = [];
 
-            public List<InterfaceDeclarationSyntax> CandidateInterfaces { get; } = new();
+            public List<InterfaceDeclarationSyntax> CandidateInterfaces { get; } = [];
 
             public void OnVisitSyntaxNode(SyntaxNode syntaxNode)
             {

Refit/ApiException.cs

@@ -9,7 +9,9 @@ namespace Refit
     /// Represents an error that occured while sending an API request.
     /// </summary>
     [Serializable]
+#pragma warning disable CA1032 // Implement standard exception constructors
     public class ApiException : Exception
+#pragma warning restore CA1032 // Implement standard exception constructors
     {
         /// <summary>
         /// HTTP response status code.
@@ -162,7 +164,12 @@ public static Task<ApiException> Create(
         )
 #pragma warning restore VSTHRD200 // Use "Async" suffix for async methods
         {
-            var exceptionMessage = CreateMessage(response.StatusCode, response.ReasonPhrase);
+            if (response?.IsSuccessStatusCode == true)
+            {
+                throw new ArgumentException("Response is successful, cannot create an ApiException.", nameof(response));
+            }
+
+            var exceptionMessage = CreateMessage(response!.StatusCode, response.ReasonPhrase);
             return Create(
                 exceptionMessage,
                 message,
@@ -211,6 +218,7 @@ public static async Task<ApiException> Create(
                 return exception;
             }
 
+#pragma warning disable CA1031 // Do not catch general exception types
             try
             {
                 exception.ContentHeaders = response.Content.Headers;
@@ -235,6 +243,7 @@ public static async Task<ApiException> Create(
                 // so we want to make sure we don't throw another one
                 // that hides the real error.
             }
+#pragma warning restore CA1031 // Do not catch general exception types
 
             return exception;
         }

Refit/CamelCaseUrlParameterKeyFormatter.cs

@@ -5,6 +5,11 @@
     /// </summary>
     public class CamelCaseUrlParameterKeyFormatter : IUrlParameterKeyFormatter
     {
+        /// <summary>
+        /// Formats the specified key.
+        /// </summary>
+        /// <param name="key">The key.</param>
+        /// <returns></returns>
         public string Format(string key)
         {
             if (string.IsNullOrEmpty(key) || !char.IsUpper(key[0]))

Refit/PushStreamContent.cs

@@ -135,11 +135,11 @@ protected override async Task SerializeToStreamAsync(
         {
             var serializeToStreamTask = new TaskCompletionSource<bool>();
 
-            Stream wrappedStream = new CompleteTaskOnCloseStream(stream, serializeToStreamTask);
-            await onStreamAvailable(wrappedStream, this, context);
+            using Stream wrappedStream = new CompleteTaskOnCloseStream(stream, serializeToStreamTask);
+            await onStreamAvailable(wrappedStream, this, context).ConfigureAwait(false);
 
             // wait for wrappedStream.Close/Dispose to get called.
-            await serializeToStreamTask.Task;
+            await serializeToStreamTask.Task.ConfigureAwait(false);
         }
 
         /// <summary>
@@ -170,6 +170,7 @@ TaskCompletionSource<bool> serializeToStreamTask
                     ?? throw new ArgumentNullException(nameof(serializeToStreamTask));
             }
 
+            [SuppressMessage("Usage", "CA2215:Dispose methods should call base class dispose", Justification = "We don't dispose the underlying stream because we don't own it. Dispose in this case just signifies that the user's action is finished.")]
             protected override void Dispose(bool disposing)
             {
                 // We don't dispose the underlying stream because we don't own it. Dispose in this case just signifies

Refit/RestMethodInfo.cs

@@ -121,7 +121,7 @@ public RestMethodInfoInternal(
                     if (attachmentName == null)
                         continue;
 
-                    attachmentDict ??= new Dictionary<int, Tuple<string, string>>();
+                    attachmentDict ??= [];
                     attachmentDict[i] = Tuple.Create(
                         attachmentName,
                         GetUrlNameForParameter(ParameterInfoArray[i])
@@ -146,7 +146,7 @@ public RestMethodInfoInternal(
                     continue;
                 }
 
-                queryDict ??= new Dictionary<int, string>();
+                queryDict ??= [];
                 queryDict.Add(i, GetUrlNameForParameter(ParameterInfoArray[i]));
             }
 
@@ -558,12 +558,12 @@ HttpMethod method
                         .DeclaringType.GetInterfaces()
                         .SelectMany(i => i.GetTypeInfo().GetCustomAttributes(true))
                         .Reverse()
-                    : Array.Empty<Attribute>();
+                    : [];
 
             var declaringTypeAttributes =
                 methodInfo.DeclaringType != null
                     ? methodInfo.DeclaringType.GetTypeInfo().GetCustomAttributes(true)
-                    : Array.Empty<Attribute>();
+                    : [];
 
             // Headers set on the declaring type have to come first,
             // so headers set on the method can replace them. Switching
@@ -581,7 +581,7 @@ HttpMethod method
                 if (string.IsNullOrWhiteSpace(header))
                     continue;
 
-                ret ??= new Dictionary<string, string?>();
+                ret ??= [];
 
                 // NB: Silverlight doesn't have an overload for String.Split()
                 // with a count parameter, but header values can contain
@@ -609,7 +609,7 @@ static Dictionary<int, string> BuildHeaderParameterMap(ParameterInfo[] parameter
 
                 if (!string.IsNullOrWhiteSpace(header))
                 {
-                    ret ??= new Dictionary<int, string>();
+                    ret ??= [];
                     ret[i] = header.Trim();
                 }
             }