Fixes issue #952 - did not write everything to output stream

[cocytus]

Refit might not write everything to the outgoing http stream depending on buffer size and the total amount of data it should sent. This PR fixes that.

Should I also create a PR for 5.2.1, since it's a pretty critical bug, I'd think?

Unsure how to create a good unit/integration test for this - any help would be appreciated.

Please check if the PR fulfills these requirements

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

[dnfadmin]

All CLA requirements met.

[cocytus]

Note: This also uses WriteAsync as opposed to Write(), which would block the calling thread until everything was written.

[cocytus]

Should I instead create a PR to 5.2.1 tag?

[clairernovotny]

Thanks! I can cherry pick the result to that branch once it's merged into main.

I would like to get a failing/fixed test that shows this -- the key is figuring out what the interface/datatype/payload was that was causing this? Something that was too big? We serialize a known array of data or a file in the test if that's it.

There's a mocking infrastructure that lets us check the contents of what the server receives, similar to this:
https://github.com/reactiveui/refit/blob/main/Refit.Tests/RestService.cs#L1406-L1429

GitHub

reactiveui/refit

The automatic type-safe REST library for .NET Core, Xamarin and .NET. Heavily inspired by Square's Retrofit library, Refit turns your REST API into a live interface. - reactiveui/refit

[cocytus]

Test added in separate commit. It fails before last commit is added.

[clairernovotny]

After cherry-picking the fix, there's a failing test on the rel/v5.2 branch: CanSerializeBigData. The BigData member is null. Any chance you could take a quick look so we can get fix out for 5.2?

[cocytus]

Created PR against 5.2 branch.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.