Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HttpContent body/return types for extra customizability. #104

Merged
merged 4 commits into from
Jun 1, 2015

Conversation

clairernovotny
Copy link
Member

This should fix #78

.OfType<InterfaceDeclarationSyntax>()
.SelectMany(i => i.Members.OfType<MethodDeclarationSyntax>())
.ToList();
.OfType<InterfaceDeclarationSyntax>()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're clearly still missing the R# setting that stops it from indenting chained method calls like this. Would be good to clean that up so we don't get unnecessary changes like this. I wonder if there's a way to disable R# entirely in test case files, because as you can see below, its "clean up" feature has busted some of the tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this on my machine, are you sure your local settings aren't somehow overriding the project settings? These indents shouldn't be happening - if I do Tools > Cleanup Code... then select Default: Reformat Code, these indents are reset to what they were before.

@bennor
Copy link
Contributor

bennor commented Jan 30, 2015

Do you reckon this will make #83 is unnecessary? With a few small changes to this PR, we could support any type that derives from HttpContent instead of just HttpContent itself, then custom serialization of any type could be achieved with a class that derives from HttpContent.

Would mean we wouldn't have to sacrifice readability/usability on the interfaces, because it would allow something like this:

public interface IWhateverApi
{
    [Get("/some-xml-endpoint")]
    XmlContent GetSomeXml();
}

@anaisbetts
Copy link
Member

@onovotny I think if you burn the "Fix formatting" commit, this might be salvageable

@anaisbetts anaisbetts merged commit 14c82f0 into reactiveui:master Jun 1, 2015
@clairernovotny clairernovotny deleted the expose-httpcontent branch August 31, 2015 03:21
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipart requests
3 participants