Header collection post without body bug #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a bug fix for
HeaderCollectionandPropertynot working correctly onPutPostandPatchwhen no[Body]attribute is present.What is the current behavior?
The original bug was filed here #1102 - essentially when no
[Body]attribute is present Refit tries to infer a body using a parameter with a value type that is not of typestringand is not marked with a[Query]attribute. The bug was caused by not adding[HeaderCollection]and[Property]attributes to that list in the original PR and not having sufficient test coverage for those Put/Post/Patch.What is the new behavior?
The
[HeaderCollection]and[Property]attributes behave correctly onPutPostandPatchrequests when no[Body]attribute is present.What might this PR break?
Nothing. I've updated the test coverage of these features significantly with respect to put/post/patch to make sure.
Please check if the PR fulfills these requirements