Adds named httpclient support #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redbaty
changed the title
Used to resolve Refit http clients
|
|
redbaty
changed the title
glennawatson
approved these changes
Apr 12, 2023
anaisbetts
added a commit
that referenced
this pull request
Apr 17, 2023
This reverts commit b78bbc7.
6 tasks
anaisbetts
added a commit
that referenced
this pull request
Apr 17, 2023
This reverts commit b78bbc7.
anaisbetts
added a commit
that referenced
this pull request
Apr 21, 2023
This reverts commit b78bbc7.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Makes it possible to set a custom name to the HTTP Client factory
What is the current behavior?
You can't use the same interface to point at multiple environments for example.
What is the new behavior?
You can use custom names to the same interface but with different environment/handlers.
What might this PR break?
In the original implementation
UniqueName.ForType<T>()was used as the client's name, so if a custom name is used it might break somewhere, tho I've looked and not found any other references for this other than tests.Please check if the PR fulfills these requirements
Other information: