Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Simplify authorization configuration #1495

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

anaisbetts
Copy link
Member

@anaisbetts anaisbetts commented Apr 17, 2023

In order to maintain backwards compatibility, we now are ending up with three separate fetchers that do the same thing. Let's instead simplify since we're doing a breaking change anyways, and that this will be pretty straightforward for developers to deal with

What kind of change does this PR introduce?
API design change

What is the current behavior?
Three separate properties to configure the same thing

What is the new behavior?
One property for the same thing

What might this PR break?
Developers will need some find-replaces to fix it

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Refs #1413

In order to maintain backwards compatibility, we now are ending up with three separate fetchers that do the same thing. Let's instead simplify since we're doing a breaking change anyways, and that this will be pretty straightforward for developers to deal with
@glennawatson glennawatson enabled auto-merge (squash) April 17, 2023 14:06
@glennawatson glennawatson merged commit 35965b8 into main Apr 17, 2023
@glennawatson glennawatson deleted the no-separate-auth-props branch April 17, 2023 14:18
@github-actions
Copy link

github-actions bot commented May 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants