Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure two interfaces with the same name do not cause compile errors #1542

Merged
merged 11 commits into from
Jun 9, 2024

Conversation

dtewinkel
Copy link
Contributor

What kind of change does this PR introduce?

Fixes bug #1261.

What is the current behavior?
See bug #1261. In short, source generator fails if there are more than two interfaces with the same name.

What is the new behavior?
Any number of interface with the same name is supported by extending the methodology that supported two interfaces with the same name.

What might this PR break?
Nothing that I expect.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@dtewinkel
Copy link
Contributor Author

Is there any documentation I should update? Version history or so?

@glennawatson
Copy link
Contributor

We are starting to evaluate another release. So will go through these PRs soon. thanks for the contribution.

Daniël te Winkel and others added 3 commits October 2, 2023 19:57
@dtewinkel
Copy link
Contributor Author

I just added a fix for the unit tests.

@anaisbetts anaisbetts changed the title Fix/bug 1261 Ensure two interfaces with the same name do not cause compile errors Dec 9, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (6ebeda5) to head (d0d1c5a).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
- Coverage   87.73%   86.62%   -1.11%     
==========================================
  Files          33       34       +1     
  Lines        2348     2064     -284     
  Branches      294      296       +2     
==========================================
- Hits         2060     1788     -272     
+ Misses        208      199       -9     
+ Partials       80       77       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit 9c2caf3 into reactiveui:main Jun 9, 2024
1 check passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants