chore: minor refactors #1619
Merged
chore: minor refactors #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMakkison
force-pushed
the
refactor
branch
from
a01cd90 to
ea83670
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
==========================================
- Coverage 87.85% 87.81% -0.04%
==========================================
Files 33 33
Lines 2354 2347 -7
Branches 295 294 -1
==========================================
- Hits 2068 2061 -7
Misses 207 207
Partials 79 79 ☔ View full report in Codecov by Sentry. |
|
Happy to merge this one in when we get it compiling. Thanks |
TimothyMakkison
force-pushed
the
refactor
branch
from
ea83670 to
20a9ac5
Compare
glennawatson
approved these changes
Nov 26, 2023
TimothyMakkison
force-pushed
the
refactor
branch
from
20a9ac5 to
10f0134
Compare
|
Sorry, ran csharpier one more time. No potential logic changes 👍 |
glennawatson
approved these changes
Nov 26, 2023
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up #1596, tried to avoid modifying the whitespace.
TryGetValueoverContainsKey/lookupToArray