feat: add husky to run csharpier #1622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 33 33
Lines 1685 1685
Branches 295 295
=======================================
Hits 1439 1439
Misses 167 167
Partials 79 79 ☔ View full report in Codecov by Sentry. |
|
Thanks. I know you had a bit of conflicting advice. I'll close for now and have a chat with others about it. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added husky to run a pre commit hook to run csharpier. The changes to csproj should install the required dotnet tools for husky.
I could add a lint step to the pipeline to run
dotnet formatandcsharpier check.Shamelessly copied from mapperly 😅
See #1617