-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MemberNotNullWhen annotation for Content / HasContent pair #1779
Add MemberNotNullWhen annotation for Content / HasContent pair #1779
Conversation
This is a continuation of #1302 |
@ChrisPulman I don't see how the error in the tests is linked to my change - can you please advise what to do?
|
I will take a look later, thank you. |
Bump Version due to API change
You had not run the tests, this would have led to a failure of the API test due to a change in the API. I added these tests in to ensure that the version is correctly managed. |
I understand, thank you for helping me! It was just that the build output didn't look like a test failure to me but more like a compilation failure (it couldn't find the DLL). |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
It adds the MemberNotNullWhen annotation to the Content / HasContent pair in ApiException.
What is the current behavior?
VS does not recognize
Content
being non-null whenHasContent
istrue
.What is the new behavior?
VS should recognize
Content
being non-null whenHasContent
istrue
.What might this PR break?
Please check if the PR fulfills these requirements
Other information: