feat: revert 29e0e1c #1819
Merged
feat: revert 29e0e1c #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update, appears to fix it for me on Rider. I tested this by creating a sandbox application see here #1820. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
==========================================
- Coverage 87.73% 83.74% -3.99%
==========================================
Files 33 36 +3
Lines 2348 2449 +101
Branches 294 345 +51
==========================================
- Hits 2060 2051 -9
- Misses 208 316 +108
- Partials 80 82 +2 ☔ View full report in Codecov by Sentry. |
ChrisPulman
approved these changes
Sep 18, 2024
|
@TimothyMakkison I will find a way to lock these versions, thank you. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1817 by reverting 29e0e1c. Not sure if
Microsoft.CodeAnalysis.CSharpwas intentionally updated to the latest versions, guessing it broke the source generator for anyone on an older ide.