Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade roslyn 4.0 to 4.1 #1828

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Sep 19, 2024

Upgrade Roslyn 4.0 to Roslyn 4.1 for access to WithTrackingName

  • bit concerned with line 29 in refit.props
  • Looks like the tests are failing because it can't find the old Roslyn 4.0 csproj

@TimothyMakkison TimothyMakkison marked this pull request as draft September 19, 2024 15:28
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (6ebeda5) to head (2996d20).
Report is 96 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
- Coverage   87.73%   83.74%   -3.99%     
==========================================
  Files          33       36       +3     
  Lines        2348     2449     +101     
  Branches      294      345      +51     
==========================================
- Hits         2060     2051       -9     
- Misses        208      316     +108     
- Partials       80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman
Copy link
Member

@TimothyMakkison all building now

@TimothyMakkison
Copy link
Contributor Author

TimothyMakkison commented Sep 19, 2024

@TimothyMakkison all building now

Thanks for fixing that, annoyed I missed the obvious reference 😅

Close to adding incremental generation, I'm currently breaking it up into smaller PRs to make it easier to review if thats okay with you.

@TimothyMakkison TimothyMakkison marked this pull request as ready for review September 19, 2024 17:49
@ChrisPulman
Copy link
Member

It's worked well until now, so let's go with the incremental changes though multiple PR's, it also makes undoing anything untoward easier.

@ChrisPulman ChrisPulman merged commit c72fa3a into reactiveui:main Sep 19, 2024
2 of 3 checks passed
Copy link

github-actions bot commented Oct 4, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants