Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add incremental generator tests #1829

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

TimothyMakkison
Copy link
Contributor

Added incremental generator tests for #1791

  • Tests should fail until I add incremental generation.

@TimothyMakkison TimothyMakkison marked this pull request as ready for review September 24, 2024 20:47
@TimothyMakkison
Copy link
Contributor Author

TimothyMakkison commented Sep 24, 2024

  • Rebased
  • Commented out [Fact] so test will pass
  • Will probably add more tests in a separate PR to break up the incremental generator PR
  • Test code could probably be simplified in future

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.79%. Comparing base (6ebeda5) to head (02e783f).
Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   87.73%   83.79%   -3.94%     
==========================================
  Files          33       36       +3     
  Lines        2348     2456     +108     
  Branches      294      346      +52     
==========================================
- Hits         2060     2058       -2     
- Misses        208      316     +108     
- Partials       80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman enabled auto-merge (squash) September 24, 2024 22:11
@ChrisPulman ChrisPulman merged commit f2ab216 into reactiveui:main Sep 24, 2024
1 check passed
@TimothyMakkison TimothyMakkison deleted the incremental_tests branch September 24, 2024 22:13
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants