-
-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes repetition from method attributes and fixes failing specs #40
Removes repetition from method attributes and fixes failing specs #40
Conversation
Hey @Balauru, it's hard to see what's changed because your editor changed the style - can you fix this up? Here's a motivating example: public void FooBar()
{
try {
if (foo == "bar") {
baz();
} else {
bamf()
}
} catch (Exception ohNoes) {
Console.WriteLine(ohNoes);
}
} You don't need to close and resubmit or anything, just push another commit and it will show up here |
Done @paulcbetts Any reference to the code style you are using here, looks a lot like java instead of the usual .net developer use. |
The change is in the |
This seems to be the same issue as #34 ... |
Yes, this is my proposed solution. |
I like it 👍 |
Looks good, I like it! Thanks @Balauru! |
Removes repetition from method attributes and fixes failing specs
Now on master:
With this pull request
It will spare you from writting
/api/v1
on all your endpoints, making it easier to update to a new api version.