Support for URL encoded form posts. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class FormValueDictionary : Dictionary<string, string> | ||
| { | ||
| // Can't use ConcurrentDictionary because Silverlight doesn't have it |
There was a problem hiding this comment.
We're not going to be constantly reading and writing to this collection from multiple threads, it's actually more efficient to just use lock in these cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is done yet. So far there's only support for URL encoded form data in the request body -- not the response. I've never come across an API that responds with form data. The Slack API is the only API I can think of that accepts form data, but it responds with JSON.
The other thing I'm not sure what to do about is XML. There was a
BodySerializationMethod.Xmlbut I removed it because, as far as I can tell, refit doesn't support XML at all yet. There was definitely nothing referring to that enum value anyway.