Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than one parameter per URL segment. #47

Merged
merged 4 commits into from
Jun 30, 2014
Merged

Allow more than one parameter per URL segment. #47

merged 4 commits into from
Jun 30, 2014

Conversation

bennor
Copy link
Contributor

@bennor bennor commented Jun 29, 2014

This change adds support for multiple parameters per URL segment.

Not sure if it goes against any RFC standards or anything, but a while back I made the (questionable?) decision to express image sizes in my app's API as "/{id}/{width}x{height}". Works fine with Web API, but Refit doesn't like it. 💣

I'm working around this in my app's client at the moment with a custom Resolution type with a .ToString() that serializes it to "{width}x{height}", so if you're not keen on allowing multiple parameters in a segment I'm happy for you to just 🔪 this PR.

@anaisbetts
Copy link
Member

Aces. Thanks @bennor!

anaisbetts pushed a commit that referenced this pull request Jun 30, 2014
Allow more than one parameter per URL segment.
@anaisbetts anaisbetts merged commit 50cbca3 into reactiveui:master Jun 30, 2014
@bennor bennor deleted the multiple-parameters-per-segment branch October 12, 2014 20:38
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants