Adds custom Json result converters in tests to demo functionality #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| namespace Refit.Tests | ||
| { | ||
| public class User | ||
| { | ||
| public string login { get; set; } |
There was a problem hiding this comment.
Sorry it's a pain in the ass, but can you save all of them?
|
@paulcbetts Send a new pull request that addresses your comments, thank you for taking the time to evaluate my changes. |
|
@Balauru You don't have to send a new pull request, just keep committing to the existing one! |
|
Sorry @paulcbetts I meant, "Send a new commit that addresses your comments ..." |
|
👍 🆒 ✨ |
|
Great, thanks @Balauru! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a example for the solution proposed by @bennor here #27