Relax Json.NET version requirements #671
Conversation
This change downgrades the Newtonsoft.Json package reference to a minimum of 9.01. We're not using any of the newer APIs, and all our tests pass, so I think this is okay. 🚀 It required adding an explicit dependency on `System.Runtime.Serialization.Formatters` to the netstandard 1.4 version, and in the process of adding that I cleaned up the 1.4 specific package references in the project a tiny bit. My only concern here is the [fairly large number of fixes in Json.NET between 9.0.1 and 12.0.2](https://github.com/JamesNK/Newtonsoft.Json/releases). This change won't stop stop anyone from referencing a later version though -- explicitly or otherwise. It just might open us up to some annoying bug reports. (As stated in the referenced issue, most people will be using a later version than 9.0.1 anyway.) So this fixes #670, I think 😂
|
I have to say, I'm not keen on using minimum versions as I tend to think that lets bugs fester. I'd venture that a significant number of people only use the transitive dependencies and don't directly reference newer versions. Is there a specific issue with the Azure Functions runtime tracking this? I thought they had been working on something so their runtime was isolated from user code. |
|
Looks like there's a functions runtime issue for it. Can't tell for certain if it's being fixed. There are about a hundred other ways AF does my head in, so in the grand scheme of things this is pretty minor. 🤣 |
|
@onovotny Is there any way to set up the package references so that people will be encouraged to use the latest version but still allow a previous version? Or is that just the default behaviour anyway? If not I think we can abandon this PR and close the related issue. |
|
@bennor not that I know of |
This change downgrades the Newtonsoft.Json package reference (i.e. Json.NET) to a minimum of 9.01. We're not using any of the newer APIs, and all our tests pass, so I think this is okay. 🚀
It required adding an explicit dependency on
System.Runtime.Serialization.Formattersto the netstandard 1.4 version, and in the process of adding that I cleaned up the 1.4 specific package references in the project a tiny bit.My only concern here is the fairly large number of fixes in Json.NET between 9.0.1 and 12.0.2. This change won't stop stop anyone from referencing a later version though -- explicitly or otherwise. It just might open us up to some annoying bug reports. (As stated in the referenced issue, most people will be using a later version than 9.0.1 anyway.)
So this fixes #670, I think 😂
What kind of change does this PR introduce?
Newtonsoft.Jsonpackage reference to a minimum of 9.01What is the current behavior?
Newtonsoft.Json12.0.1 or higher (see Be less aggressive with dependency updates in core library? #670.)What is the new behavior?
What might this PR break?
It could expose us to bug reports for any of the issues fixed in Json.NET since 9.0.1.
Please check if the PR fulfills these requirements