Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest coverlet #902

Merged
merged 4 commits into from
Apr 18, 2020
Merged

latest coverlet #902

merged 4 commits into from
Apr 18, 2020

Conversation

clairernovotny
Copy link
Member

No description provided.

@clairernovotny
Copy link
Member Author

clairernovotny commented Apr 12, 2020 •
edited
Loading

@MarcoRossignoli @tmat

Getting errors here using the 1.3.x nightly of the collectors

C:\Program Files\dotnet\sdk\5.0.100-preview.2.20176.6\Roslyn\Microsoft.Managed.Core.targets(104,5): error : SourceRoot
items must include at least one top-level (not nested) item when DeterministicSourcePaths is true [D:\dev\refit\Refit\R
efit.csproj]

This issue occurs when the Test project has Deterministic set to false but the projects under test are normal.

Repro is

dotnet test /p:ContinuousIntegrationBuild=true

@clairernovotny
Copy link
Member Author

clairernovotny commented Apr 12, 2020 •
edited
Loading

I wonder if there's a dependency/ordering issue:

image

The InitializeSourceControlInformation target shows as grey in that call path.

MarcoRossignoli
MarcoRossignoli reviewed Apr 12, 2020
View reviewed changes
Directory.Build.targets
@@ -7,4 +7,13 @@ https://github.com/dotnet/sourcelink/issues/572 -->
<ItemGroup>
<EmbeddedFiles Include="$(GeneratedAssemblyInfoFile)"/>
</ItemGroup>

<Target Name="CoverletGetPathMap"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you missing?

  <ItemGroup>
    <SourceRoot Include="$(NuGetPackageRoot)" />
  </ItemGroup>

Copy link
Member Author

@clairernovotny clairernovotny Apr 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need that here. That workaround is only needed for packages that contain source files.

@MarcoRossignoli MarcoRossignoli mentioned this pull request Apr 13, 2020
Closed
@clairernovotny clairernovotny merged commit 4a05957 into master Apr 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the latest-coverlet branch April 18, 2020 14:13
@clairernovotny clairernovotny added the dependencies Pull requests that update a dependency file label Nov 26, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clairernovotny @MarcoRossignoli