Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Release of Net 8.0 #1064

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Update to Release of Net 8.0 #1064

merged 2 commits into from
Nov 15, 2023

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fix code recommendations where relevant

What is the current behavior?

RC version of net 8.0

What is the new behavior?

Release version of net 8.0

What might this PR break?

none expected

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
Latest VS2022 release required for development of Splat as of today

Fix code recommendations where relevant
The latest version seams to be missing Android SDK platform for API level 31
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (42980da) 74.27% compared to head (a06bcd1) 74.14%.

Files Patch % Lines
src/Splat/Maths/PointMathExtensions.cs 0.00% 5 Missing ⚠️
src/Splat.Drawing/Bitmaps/BitmapLoader.cs 0.00% 4 Missing ⚠️
src/Splat/Logging/LogHost.cs 40.00% 1 Missing and 2 partials ⚠️
src/Splat/Logging/DefaultLogManager.cs 50.00% 1 Missing and 1 partial ⚠️
...icationInsights/ApplicationInsightsViewTracking.cs 0.00% 1 Missing ⚠️
src/Splat.Drawing/Colors/SplatColor.cs 80.00% 1 Missing ⚠️
src/Splat/Disposables/BooleanDisposable.cs 0.00% 1 Missing ⚠️
src/Splat/Logging/WrappingFullLogger.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   74.27%   74.14%   -0.14%     
==========================================
  Files          95       95              
  Lines        5520     5530      +10     
  Branches      631      632       +1     
==========================================
  Hits         4100     4100              
- Misses       1216     1226      +10     
  Partials      204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpvreony
Copy link
Member

do we need to bump version.json? minor version?

@ChrisPulman
Copy link
Member Author

There is a small API change so yes we need to bump, however we need to review the TargetFrameworks of Drawing as some of the Android targets seem to have been dropped since yesterday (14th November) in the latest release of Visual Studio which will affect our build process shortly.

Let's review the targets before making a release.

@ChrisPulman ChrisPulman merged commit f63a155 into main Nov 15, 2023
1 of 3 checks passed
@ChrisPulman ChrisPulman deleted the CP_UpdateToReleaseNet8_0 branch November 15, 2023 06:21
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants